Upgrade {gas-fee,notification-services}-controller #12565
Closed
+24
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected] |
mcmire
added
Run Smoke E2E
- Bump `@metamask/gas-fee-controller` from 21.0.0 to 22.0.2 ([view changes](https://github.com/MetaMask/core/blob/main/packages/gas-fee-controller/CHANGELOG.md)) - There are no notable changes between these versions. - Bump `@metamask/notification-services-controller` from 0.11.0 to 0.15.0 ([view changes](https://github.com/MetaMask/core/blob/main/packages/notification-services-controller/CHANGELOG.md)) - Notable changes in 0.12.0: - `deleteNotificationsById` now publishes `NotificationServicesController:notificationsListUpdated` - Notable changes in 0.12.1: - When notifications are disabled, list is now repopulated with Snap notifications
7 tasks
mcmire
changed the title
|
|
Superseded by #12577. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to ensure that mobile is using the latest versions of all controllers.
@metamask/gas-fee-controllerfrom 21.0.0 to 22.0.2 (view changes)@metamask/notification-services-controllerfrom 0.11.0 to 0.15.0 (view changes)deleteNotificationsByIdnow publishesNotificationServicesController:notificationsListUpdatedRelated issues
Progresses https://github.com/MetaMask/MetaMask-planning/issues/3698 (and does more to satisfy peer dependency warnings).
Manual testing steps
(TODO)
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist